[PATCH] D66924: [NewGVN] Add phi-of-ops instr as user of FoundVal.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

If nobody else steps up to review, I will, I guess... although I probably won't have time next week.

Some very basic questions to help me get up to speed:

1. It looks like AdditionalUsers is related to the "In order to make the GVN mostly-complete" paragraph in the top of the file?  What's the general rule for figuring out whether a given user needs to be marked?
2. It looks like there are currently seven callers of addAdditionalUsers, and this patch brings it up to 8.  Do you think with this patch, we've covered all the places that need to call it?  Are there any patterns related to addAdditionalUsers which could be refactored?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66924/new/

https://reviews.llvm.org/D66924