[PATCH] D73435: [ValueTracking] Add DemandedElts support to computeKnownBits/ComputeNumSignBits (PR36319)

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon marked an inline comment as done.
RKSimon added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:174-175
+  for (int i = 0; i != NumMaskElts; ++i) {
+    if (!DemandedElts)
+      continue;
+    int M = Shuf->getMaskValue(i);
----------------
lebedev.ri wrote:
> Wait, don't you want `DemandedElts[i]` here?
Nice catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73435/new/

https://reviews.llvm.org/D73435