[PATCH] D73763: [DSE] Lift post-dominance restriction.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D73763#1852269 <https://reviews.llvm.org/D73763#1852269>, @efriedma wrote:

> > Currently the patch uses a hack to create those MemoryUses: it just introduces a readonly function call at the end of each function
>
> I'm not deeply familiar with the MemorySSA datastructures, but that makes sense.  I'm trying to think if any other passes care, though.  I can't come up with anything off the top of my head, but maybe I'm forgetting something.


Currently the pass cleans up the artificial uses it introduces at the end, so other passes should not be impacted, unless I am missing something. The fact that they only alias objects visible to the caller after the function returns is only modelled directly in DSE and leaving them around could potentially slightly pessimize other passes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73763/new/

https://reviews.llvm.org/D73763