[PATCH] D73577: [compiler-rt] Build all alias in builtin as private external on Darwin

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 31 11:03:26 PST 2020


delcypher added a comment.

@steven_wu Thanks for fixing the text.

I can't comment on the use of `.private_extern` because I'm not familiar with it. Using the `VISIBILITY_HIDDEN` macro which seems to be defined by `darwin_add_builtin_libraries()` seems reasonable. I don't know about the OS builtin libraries though. Any thoughts @kledzik ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73577/new/

https://reviews.llvm.org/D73577





More information about the llvm-commits mailing list