[PATCH] D73733: [mlir] [VectorOps] fixed bug in vector.insert_strided_slice lowering

[Aart Bik via Phabricator via llvm-commits]

aartbik added inline comments.


================
Comment at: mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir:7
 }
-// CHECK-LABEL: broadcast_vec1d_from_scalar
+// CHECK-LABEL: llvm.func @broadcast_vec1d_from_scalar
 //       CHECK:   llvm.mlir.undef : !llvm<"<2 x float>">
----------------
ftynse wrote:
> Nit: these changes to the test look orthogonal to the commit
They are, but most teams allow minor drive-by comments, I hope that is okay here too.
In this case, I was a bit triggered by the different formats for the LABEL check ;-)


================
Comment at: mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir:540
+}
+// CHECK-LABEL: llvm.func @insert_strided_slice3(%arg0: !llvm<"[2 x <4 x float>]">, %arg1: !llvm<"[16 x [4 x <8 x float>]]">)
+//      CHECK: %[[s0:.*]] = llvm.extractvalue %arg1[0] : !llvm<"[16 x [4 x <8 x float>]]">
----------------
ftynse wrote:
> Let's capture SSA names for arguments as well:
> 
> ```
> CHECK-LABEL: llvm.func @insert_strided_slice3
> CHECK-SAME: %[[arg0:.*]]: !llvm<
> CHECK-SAME: %[[arg1:.*]]: !llvm<
> ```
> 
> (`CHECK-LABEL` does not support capture)
Also did the other occurrences for consistency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73733/new/

https://reviews.llvm.org/D73733