[PATCH] D73795: [mlir] Drop customization hooks from StandardToLLVM conversion

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 31 10:54:22 PST 2020


ftynse created this revision.
ftynse added reviewers: nicolasvasilache, dcaballe.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a project: LLVM.

These hooks were originally introduced to support passes deriving the
StandardToLLVM conversion, in particular converting types from different
dialects to LLVM types in a single-step conversion. They are no longer in use
since the pass and conversion infrastructure has evolved sufficiently to make
defining new passes with exactly the same functionality simple through the use
of populate* functions, conversion targets and type converters. Remove the
hooks. Any users of this hooks can call the dialect conversion infrastructure
directly instead, which is likely to require less LoC than these hooks.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73795

Files:
  mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVMPass.h
  mlir/lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73795.241773.patch
Type: text/x-patch
Size: 6970 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200131/3eae1631/attachment.bin>


More information about the llvm-commits mailing list