[PATCH] D73793: Improve error message of FileCheck when stdin is empty

Dave Bozier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 31 09:59:01 PST 2020


davidb marked an inline comment as done.
davidb added inline comments.


================
Comment at: llvm/utils/FileCheck/FileCheck.cpp:619
+      MemoryBuffer::getFileOrSTDIN(
+          (InputFilename == "<stdin>" ? "-" : InputFilename.getValue()));
   if (std::error_code EC = InputFileOrErr.getError()) {
----------------
I found it the least intrusive and confusing to change the InputFilename of stdin here, than in the other 3 places that the InputFilename is printed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73793/new/

https://reviews.llvm.org/D73793





More information about the llvm-commits mailing list