[PATCH] D71593: [DebugInfo] Call site entries cannot be generated for FrameSetup calls

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

It's hard for me to imagine a case where a frame-setup prologue requires a call that really wants debug info.  For the save/restore example in D62686 <https://reviews.llvm.org/D62686>, the calls are to system/library helpers to support a size optimization, and as such seem like an implementation detail (along the lines of, say, implementing integer divide as a lib call when you don't have a hardware instruction).  So, skipping FrameSetup instructions seems like the right tactic, although the justification in the comment isn't really the right reason.

I can see that a test here could depend on save/restore landing first, but I don't see them as co-dependent.  The other one introduces the calls that become an issue for debug info, this one fixes the debug-info issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71593/new/

https://reviews.llvm.org/D71593