[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

In D73534#1850372 <https://reviews.llvm.org/D73534#1850372>, @vsk wrote:

> In D73534#1849382 <https://reviews.llvm.org/D73534#1849382>, @djtodoro wrote:
>
> > @vsk Thanks a lot for sharing this!
> >
> > > (however the machine was not stabilized for perf measurements)
> >
> > What can be the reason of that?
>
>
> Stabilization entails removing variables from the system that can affect performance. This usually entails killing extraneous background processes and disabling cpu frequency scaling. This can make the system hard to use (e.g. our stabilization script kills the bluetooth daemon, which I need to type).


OK, thanks for the info. I see, you said your machine was not stable. I thought the `debug_info`made the performance to looking bad. Sorry :)

> I have some numbers for stage2 clang builds on macOS:
> 
> | Config                            | dSYM Size (bytes) | Aggregate DWARF size in .o's (bytes) [1] | # of call site DIEs | # of call site parameters |
> | Stage2 RelWithDebInfo             | 1682677554                 | 8058178927                                        | 417517              | 0                         |
> | Stage2 RelWithDebInfo + entryvals | 1691586966                 | 8069013985                                        | 417517              | 584620                    |
> |
> 
> EDIT: I miscounted earlier. I looked at the number of 'call site entries' instead of the number of 'call site DIEs'. I've updated the table with the correct numbers, which look fine to me.
> 
> [1] Just summing the size of all 'DWARF' sections in all .o's in the build directory, as before.

Thanks for sharing this! The numbers look very good to me!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73534/new/

https://reviews.llvm.org/D73534