[PATCH] D67687: [CodeGen] Define an interface for the new pass manager. (new)

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: wdng.

LGTM with nits



================
Comment at: llvm/include/llvm/CodeGen/PassManager.h:58
+  template <typename PassT> typename PassT::Result &getResult(const Module &M) {
+    assert (MAM);
+    return MAM->getResult<PassT>(const_cast<Module &>(M));
----------------
Extra space before (


================
Comment at: llvm/include/llvm/CodeGen/PassManager.h:63
+  typename PassT::Result &getResult(const Function &F) {
+    assert (FAM);
+    return FAM->getResult<PassT>(const_cast<Function &>(F));
----------------
Ditto


================
Comment at: llvm/unittests/CodeGen/PassManagerTest.cpp:139
+  const Target *T =
+      TargetRegistry::lookupTarget("x86_64-unknonwn-linux", Error);
+  assert(T);
----------------
Typo unknonwn


================
Comment at: llvm/unittests/CodeGen/PassManagerTest.cpp:144
+  std::unique_ptr<TargetMachine> TM(
+      T->createTargetMachine("x86_64-unknonwn-linux", "", "", Options, None,
+                             None, CodeGenOpt::Aggressive));
----------------
Typo unknonwn


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67687/new/

https://reviews.llvm.org/D67687