[PATCH] D73710: [VE] vaarg functions callers and callees

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 31 07:50:09 PST 2020


simoll added inline comments.


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.h:64-77
+  unsigned isLoadFromStackSlot(const MachineInstr &MI,
+                             int &FrameIndex) const override;
+  unsigned isStoreToStackSlot(const MachineInstr &MI,
+                              int &FrameIndex) const override;
+  void storeRegToStackSlot(MachineBasicBlock &MBB,
+                           MachineBasicBlock::iterator MBBI, unsigned SrcReg,
+                           bool isKill, int FrameIndex,
----------------
arsenm wrote:
> These are overdue for conversion to Register
Yep. I'll work on a followup patch for the conversion next week.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73710/new/

https://reviews.llvm.org/D73710





More information about the llvm-commits mailing list