[PATCH] D73746: [AArch64][SVE] Add SVE2 mla unpredicated intrinsics.

Danilo Carvalho Grael via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 31 07:50:06 PST 2020


dancgr added a comment.

In D73746#1851678 <https://reviews.llvm.org/D73746#1851678>, @kmclaughlin wrote:

> Thanks for these changes, @dancgr! I just have a couple of comments on the tests in sve2-mla-unpredicated.ll


I also added the missing i16 tests.



================
Comment at: llvm/test/CodeGen/AArch64/sve2-mla-unpredicated.ll:18
+
+define <vscale x 4 x i32> @smlalb_i32_2(<vscale x 4 x i32> %a,
+                                        <vscale x 8 x i16> %b,
----------------
kmclaughlin wrote:
> This test looks to be identical to the one above other than the name, and I noticed that a few others below are also repeated in a similar way. Was this on purpose?
No, that was an oversight. I should have removed those before uploading, will re-upload the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73746/new/

https://reviews.llvm.org/D73746





More information about the llvm-commits mailing list