[PATCH] D73785: [NFC] Introduce a type to model memory operation
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 31 07:41:16 PST 2020
courbet added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5911
unsigned Limit = AlwaysInline ? ~0U : TLI.getMaxStoresPerMemcpy(OptSize);
-
+ MemOp Op = isZeroConstant ? MemOp::Set(Size, DstAlignCanChange, Alignment,
+ /*IsZeroMemset*/ true, isVol)
----------------
Could you submit the fix to the broken `isZeroConstant` code as a separate patch so that this remains an NFC ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73785/new/
https://reviews.llvm.org/D73785
More information about the llvm-commits
mailing list