[llvm] b3726ec - AMDGPU: Fix potential use of undefined value

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 31 07:39:09 PST 2020


Author: Matt Arsenault
Date: 2020-01-31T10:38:58-05:00
New Revision: b3726ecea4bc96f9fa3218e5be47ea0f2054b0dc

URL: https://github.com/llvm/llvm-project/commit/b3726ecea4bc96f9fa3218e5be47ea0f2054b0dc
DIFF: https://github.com/llvm/llvm-project/commit/b3726ecea4bc96f9fa3218e5be47ea0f2054b0dc.diff

LOG: AMDGPU: Fix potential use of undefined value

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp b/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
index 62fc6f56a0cf..231ed5449969 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
@@ -1796,7 +1796,6 @@ bool AMDGPUDAGToDAGISel::SelectSMRDOffset(SDValue ByteOffsetNode,
   Offset = SDValue(
       CurDAG->getMachineNode(AMDGPU::S_MOV_B32, SL, MVT::i32, C32Bit), 0);
 
-  Imm = false;
   return true;
 }
 
@@ -1850,7 +1849,7 @@ bool AMDGPUDAGToDAGISel::SelectSMRD(SDValue Addr, SDValue &SBase,
 
 bool AMDGPUDAGToDAGISel::SelectSMRDImm(SDValue Addr, SDValue &SBase,
                                        SDValue &Offset) const {
-  bool Imm;
+  bool Imm = false;
   return SelectSMRD(Addr, SBase, Offset, Imm) && Imm;
 }
 
@@ -1859,7 +1858,7 @@ bool AMDGPUDAGToDAGISel::SelectSMRDImm32(SDValue Addr, SDValue &SBase,
 
   assert(Subtarget->getGeneration() == AMDGPUSubtarget::SEA_ISLANDS);
 
-  bool Imm;
+  bool Imm = false;
   if (!SelectSMRD(Addr, SBase, Offset, Imm))
     return false;
 
@@ -1868,14 +1867,14 @@ bool AMDGPUDAGToDAGISel::SelectSMRDImm32(SDValue Addr, SDValue &SBase,
 
 bool AMDGPUDAGToDAGISel::SelectSMRDSgpr(SDValue Addr, SDValue &SBase,
                                         SDValue &Offset) const {
-  bool Imm;
+  bool Imm = false;
   return SelectSMRD(Addr, SBase, Offset, Imm) && !Imm &&
          !isa<ConstantSDNode>(Offset);
 }
 
 bool AMDGPUDAGToDAGISel::SelectSMRDBufferImm(SDValue Addr,
                                              SDValue &Offset) const {
-  bool Imm;
+  bool Imm = false;
   return SelectSMRDOffset(Addr, Offset, Imm) && Imm;
 }
 
@@ -1883,7 +1882,7 @@ bool AMDGPUDAGToDAGISel::SelectSMRDBufferImm32(SDValue Addr,
                                                SDValue &Offset) const {
   assert(Subtarget->getGeneration() == AMDGPUSubtarget::SEA_ISLANDS);
 
-  bool Imm;
+  bool Imm = false;
   if (!SelectSMRDOffset(Addr, Offset, Imm))
     return false;
 


        


More information about the llvm-commits mailing list