[PATCH] D73710: [VE] vaarg functions callers and callees

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.cpp:311
+      MI.getOpcode() == VE::LDUri     // F32
+  ) {
+    if (MI.getOperand(1).isFI() && MI.getOperand(2).isImm() &&
----------------
Formatting


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.h:64-77
+  unsigned isLoadFromStackSlot(const MachineInstr &MI,
+                             int &FrameIndex) const override;
+  unsigned isStoreToStackSlot(const MachineInstr &MI,
+                              int &FrameIndex) const override;
+  void storeRegToStackSlot(MachineBasicBlock &MBB,
+                           MachineBasicBlock::iterator MBBI, unsigned SrcReg,
+                           bool isKill, int FrameIndex,
----------------
These are overdue for conversion to Register


================
Comment at: llvm/test/CodeGen/VE/va_callee.ll:80
+
+define i32 @va_copy8(i32, ...) {
+  %va = alloca i8*, align 8
----------------
Missing checks in other functions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73710/new/

https://reviews.llvm.org/D73710