[PATCH] D73287: AMDGPU/GlobalISel: Combine FMIN_LEGACY/FMAX_LEGACY

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 31 06:42:49 PST 2020


arsenm added a comment.

In D73287#1851136 <https://reviews.llvm.org/D73287#1851136>, @kerbowa wrote:

> Is anything preventing from adding a post legalizer combiner pass then?
>
> LGTM


Most of our target combines belong post-legalize and post-regbankselect. I'm mostly just unsure how to organize the 3 combiner passes which largely overlap. I'm not sure if we should juts have one combiner pass run in 3 different modes, or actually 3 distinct passes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73287/new/

https://reviews.llvm.org/D73287





More information about the llvm-commits mailing list