[PATCH] D73746: [AArch64][SVE] Add SVE2 mla unpredicated intrinsics.

[Kerry McLaughlin via Phabricator via llvm-commits]

kmclaughlin added a comment.

Thanks for these changes, @dancgr! I just have a couple of comments on the tests in sve2-mla-unpredicated.ll



================
Comment at: llvm/test/CodeGen/AArch64/sve2-mla-unpredicated.ll:18
+
+define <vscale x 4 x i32> @smlalb_i32_2(<vscale x 4 x i32> %a,
+                                        <vscale x 8 x i16> %b,
----------------
This test looks to be identical to the one above other than the name, and I noticed that a few others below are also repeated in a similar way. Was this on purpose?


================
Comment at: llvm/test/CodeGen/AArch64/sve2-mla-unpredicated.ll:718
+declare <vscale x 4 x i32> @llvm.aarch64.sve.smlalb.nxv4i32(<vscale x 4 x i32>, <vscale x 8 x i16>, <vscale x 8 x i16>)
+declare <vscale x 2 x i64> @llvm.aarch64.sve.smlalb.nxv2i64(<vscale x 2 x i64>, <vscale x 4 x i32>, <vscale x 4 x i32>)
+declare <vscale x 4 x i32> @llvm.aarch64.sve.smlalt.nxv4i32(<vscale x 4 x i32>, <vscale x 8 x i16>, <vscale x 8 x i16>)
----------------
I see you have added tests for the nxv2i64 and nxv4i32 types for each intrinsic, but not for nxv8i16. Can you please add these tests here also?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73746/new/

https://reviews.llvm.org/D73746