[PATCH] D73165: [MLIR][Linalg] Allow fusion of more than 2 linalg ops.

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache accepted this revision.
nicolasvasilache added a comment.
This revision is now accepted and ready to land.

Approved conditioned on beefing up the test and having no reordering surprises.



================
Comment at: mlir/test/Dialect/Linalg/fusion.mlir:270
 // CHECK:        linalg.matmul
+// CHECK:        linalg.matmul
 
----------------
Sorry for being annoying but there is a risk of bad ordering here and I cannot tell whether this is correct.
Could we extend the test to capture the subviews into A, B, C, D

In the end we can only have:
```
linalg.matmul(%A, %B, %C) 
linalg.matmul(%C, %B, %D)
linalg.matmul(%5, %7, %8)
```
i.e. we need to make sure that there is no bypass.
It should be fine but I'd prefer to check this new behavior.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73165/new/

https://reviews.llvm.org/D73165