[PATCH] D73769: Make gpu.launch implicitly capture uses of values defined above.

[Alex Zinenko via Phabricator via llvm-commits]

ftynse accepted this revision.
ftynse added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Dialect/GPU/Transforms/KernelOutlining.cpp:148
+                                  gpu::GPUFuncOp kernelFunc,
+                                  llvm::ArrayRef<Value> operands) {
   OpBuilder builder(launchOp);
----------------
ValueRange operands

(side nit: we re-export `ArrayRef` in the `mlir` namespace so drop `llvm::` for it)


================
Comment at: mlir/test/Dialect/GPU/invalid.mlir:4
 func @not_enough_sizes(%sz : index) {
-  // expected-error at +1 {{expected 6 or more operands}}
+  // expected-error at +1 {{expected 6}}
   "gpu.launch"(%sz, %sz, %sz, %sz, %sz) ({
----------------
6 operands


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73769/new/

https://reviews.llvm.org/D73769