[PATCH] D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib

Marius Brehler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 31 05:11:27 PST 2020


marbre created this revision.
marbre added reviewers: jpienaar, nicolasvasilache, rriddle.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, burmako, mehdi_amini, mgorny.
Herald added a project: LLVM.

- Rename CMake target MLIROptMain to MLIROpt
- Rename MlirOptMain function and sources files to MlirOpt
- Rename CMake target MLIRMlirOptLib to MLIRMlirOpt

At the moment, the Bazel configuration of TenorFlow maps the target MlirOptLib to "lib/Support/MlirOptMain.cpp" and MlirOptMain to "tools/mlir-opt/mlir-opt.cpp". This is the other way around in the CMake configuration. As discussed in the context of the pull request https://github.com/tensorflow/tensorflow/pull/36301, it seems useful to revise the naming in the MLIR repo.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73778

Files:
  mlir/include/mlir/Support/MlirOpt.h
  mlir/include/mlir/Support/MlirOptMain.h
  mlir/lib/Support/CMakeLists.txt
  mlir/lib/Support/MlirOpt.cpp
  mlir/lib/Support/MlirOptMain.cpp
  mlir/tools/mlir-opt/CMakeLists.txt
  mlir/tools/mlir-opt/mlir-opt.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73778.241701.patch
Type: text/x-patch
Size: 5269 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200131/5a4b425e/attachment.bin>


More information about the llvm-commits mailing list