[PATCH] D72992: [llvm-objdump] - Add column headers for relocation printing
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 31 04:32:25 PST 2020
grimar added a comment.
I have no more comments except the single nit.
Perhaps @jhenderson should give a final approve for this.
================
Comment at: llvm/test/tools/llvm-objdump/relocations-elf.test:157
+# ELF32-NEXT:00000001 R_386_NONE global+0x1
+# ELF32-NEXT:00000002 R_386_NONE local+0x2
+
----------------
I'd use `R_386_PC32` here to be consistent with `local` above.
The consistency is important for readability.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72992/new/
https://reviews.llvm.org/D72992
More information about the llvm-commits
mailing list