[PATCH] D73531: [llvm-objdump] avoid crash disassembling unknown instruction

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer marked an inline comment as done.
SjoerdMeijer added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ARM/unknown-instr.test:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-objdump -D -triple=thumbv8.1m.main-none-eabi -mattr=+mve %t | FileCheck %s
----------------
jhenderson wrote:
> jhenderson wrote:
> > jhenderson wrote:
> > > To be clear, does this test result in a crash without your fix?
> > > 
> > > It would be a good idea to add a comment to the top of this test to explain what is going on, why you use the switches you do, and why you use the content you do.
> > I'd still like a comment explaining what this test is doing.
> Oops, you got in as I posted this :)
yep, forgot that, but did that in a follow up just before you added this comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73531/new/

https://reviews.llvm.org/D73531