[PATCH] D73686: [llvm-readobj][test] - Cleanup testing of the --sections command line option.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with two comments.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/sections.test:2
+## Check how llvm-readobj prints sections with --sections.
+## We test the --sections flag for llvm-readelf tool in the gnu-sections.test.
 
----------------
You can delete "tool" from this sentence.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/sections.test:9
 
-## Check flag aliases produce identical output.
-# RUN: llvm-readobj --sections %p/Inputs/trivial.obj.elf-i386 > %t.sections
-# RUN: llvm-readobj -S %p/Inputs/trivial.obj.elf-i386 > %t.uppers
-# RUN: cmp %t.sections %t.uppers
-# RUN: llvm-readobj -S %p/Inputs/trivial.obj.elf-i386 > %t.lowers
-# RUN: cmp %t.sections %t.lowers
+## Check that llvm-readobj --sections flag aliases produce an identical output.
+# RUN: llvm-readobj --sections %t64 > %t64.llvm.sections
----------------
I'm not sure you need to change this comment. It's clear this test is testing the --sections option, so I don't think you need to be any more verbose than the old comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73686/new/

https://reviews.llvm.org/D73686