[PATCH] D70972: [AIX] Make sure we use export lists for plugins

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/CMakeLists.txt:842
+  string(REPLACE "-Wl,-brtl" "" CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS}")
+  string(REPLACE "-G " "" CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS
+    "${CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS}")
----------------
daltenty wrote:
> hubert.reinterpretcast wrote:
> > hubert.reinterpretcast wrote:
> > > No need to change `CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS`? Also, I'm wondering if it is more appropriate to hook in at [[ https://cmake.org/cmake/help/v3.16/variable/CMAKE_LANG_CREATE_SHARED_LIBRARY.html | CMAKE_<LANG>_CREATE_SHARED_LIBRARY ]].
> > This would not handle `-G` in all positions and would not properly handle `-G` passed via `-Wl`. Please consider for all lines.
> Updated to to be position independent. As above, we know CMake will not pass this via -Wl, so there is no need to address that case here since we are only interested in filtering the CMake defaults.
I know we've been focused on the XL-based build, but the "GCC" path for CMake //did// pass `-G` via `-Wl`: https://gitlab.kitware.com/cmake/cmake/commit/3fb3157dae5427b6c86949ec1603986c57602658

We might as well fix the issue proactively if there is reason to suspect that we will switch to a different build compiler (such as Clang).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70972/new/

https://reviews.llvm.org/D70972