[PATCH] D71593: [DebugInfo] Call site entries cannot be generated for FrameSetup calls

Thu Jan 30 13:42:59 PST 2020

dblaikie added a comment.

In D71593#1816687 <https://reviews.llvm.org/D71593#1816687>, @lewis-revill wrote:

> In D71593#1810372 <https://reviews.llvm.org/D71593#1810372>, @dblaikie wrote:
>
> > What about going the other way, and making sure instructions in frame setup that need labels get them?
>
>
> I guess it depends if people think there is an advantage to having compiler generated calls within frame setup labelled with DW_AT_return_pc. I don't know debug information well enough to say if it makes sense or not.

Would be good to rope someone who is familiar to chime in on this review, then.

In D71593#1816698 <https://reviews.llvm.org/D71593#1816698>, @lewis-revill wrote:

> In D71593#1816377 <https://reviews.llvm.org/D71593#1816377>, @djtodoro wrote:
>
> > Please add a test case.
>
>
> I think adding a test case would make this patch and save/restore codependent, unless there is another way to generate a call marked as frame-setup.

It's not uncommon that a test in one feature might need to depend on certain functionality in another feature (most abundantly - LLVM IR parsing/emission is exercised in lots of other tests). Is the codependence you're referring to likely to be especially brittle? (are there no simple, unambiguous cases that would trigger this codepath for testing that aren't likely to be purturbed by improvements/changes to save/restore?)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71593/new/

https://reviews.llvm.org/D71593