[PATCH] D73761: AMDGPU/GlobalISel: Legalize llvm.amdgcn.s.buffer.load

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: aemerson, aditya_nandakumar, paquette, nhaehnle, kerbowa, dsanders, Petar.Avramovic.
Herald added subscribers: hiraditya, t-tye, tpr, dstuttard, rovka, yaxunl, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.
arsenm added a parent revision: D73759: GlobalISel: Make LegalizerHelper primitives public.

The 96-bit results need to be widened.

     

I find the interaction between LegalizerHelper and MIRBuilder somewhat
 awkward. The custom legalization is called by the LegalizerHelper, but
then does not have access to the helper. You have to construct a new
helper, which then does not own the MachineIRBuilder, but does modify
 it. Maybe custom legalization should be passed the helper?


https://reviews.llvm.org/D73761

Files:
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.s.buffer.load.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73761.241627.patch
Type: text/x-patch
Size: 8742 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200131/b9f9c493/attachment.bin>