[PATCH] D72695: [MachO] Add a test for detecting reserved unit length.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 17:09:09 PST 2020


dblaikie added a comment.

In D72695#1850839 <https://reviews.llvm.org/D72695#1850839>, @ikudrin wrote:

> In D72695#1850551 <https://reviews.llvm.org/D72695#1850551>, @dblaikie wrote:
>
> > In D72695#1830559 <https://reviews.llvm.org/D72695#1830559>, @ikudrin wrote:
> >
> > > Thank you! I'll fix that. For some reason, I did not receive the notification from the build bot.
> >
> >
> > Did this get fixed? In what revision? (it's nice to follow-up on these threads to include where the fix was made so others can check back to see if they've picked up the fix, etc)
>
>
> The fix commit references this review, so it is mentioned in the header, in Detail/Commits section. Well, maybe that is not that clear as I expected. https://reviews.llvm.org/rG6b4f86f65f165249cbea1d23611ac97aeec7a082


Ah, indeed - thanks for the pointers!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72695/new/

https://reviews.llvm.org/D72695





More information about the llvm-commits mailing list