[PATCH] D73754: [CodeGenPrepare] Make TargetPassConfig required

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: arsenm, chandlerc, spatel, thegameg.
Herald added subscribers: llvm-commits, jsji, hiraditya, wdng, nemanjai.
Herald added a project: LLVM.

The code paths in the absence of TargetMachine, TargetLowering or
TargetRegisterInfo are poorly tested. As rL285987 <https://reviews.llvm.org/rL285987> said, requiring
TargetPassConfig allows us to delete many (untested) checks littered
everywhere.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73754

Files:
  llvm/lib/CodeGen/CodeGenPrepare.cpp
  llvm/test/CodeGen/AArch64/sve-vscale.ll
  llvm/test/CodeGen/Generic/dont-remove-empty-preheader.ll
  llvm/test/CodeGen/PowerPC/splitstore-check-volatile.ll
  llvm/test/CodeGen/X86/dont-remove-empty-preheader.ll
  llvm/test/DebugInfo/Generic/codegenprep-value.ll
  llvm/test/DebugInfo/Generic/sunk-compare.ll
  llvm/test/DebugInfo/X86/codegenprep-value.ll
  llvm/test/DebugInfo/X86/sunk-compare.ll
  llvm/test/Other/2007-04-24-eliminate-mostly-empty-blocks.ll
  llvm/test/Transforms/CodeGenPrepare/X86/bitreverse-hang.ll
  llvm/test/Transforms/CodeGenPrepare/X86/gep-unmerging.ll
  llvm/test/Transforms/CodeGenPrepare/X86/invariant.group.ll
  llvm/test/Transforms/CodeGenPrepare/X86/memset_chk-simplify-nobuiltin.ll
  llvm/test/Transforms/CodeGenPrepare/X86/split-indirect-loop.ll
  llvm/test/Transforms/CodeGenPrepare/X86/widenable-condition.ll
  llvm/test/Transforms/CodeGenPrepare/bitreverse-hang.ll
  llvm/test/Transforms/CodeGenPrepare/gep-unmerging.ll
  llvm/test/Transforms/CodeGenPrepare/invariant.group.ll
  llvm/test/Transforms/CodeGenPrepare/split-indirect-loop.ll
  llvm/test/Transforms/CodeGenPrepare/widenable-condition.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73754.241610.patch
Type: text/x-patch
Size: 18532 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200131/0a39e220/attachment.bin>