[PATCH] D73403: GlobalISel: Translate vector GEPs

Thu Jan 30 16:32:35 PST 2020

aemerson added a comment.

In D73403#1849250 <https://reviews.llvm.org/D73403#1849250>, @arsenm wrote:

> In D73403#1848263 <https://reviews.llvm.org/D73403#1848263>, @paquette wrote:
>
> > This is causing an assertion error in consumer-typeset for AArch64 at -O3.
> >
> > llvm-test-suite/MultiSource/Benchmarks/MiBench/consumer-typeset/z29.c
> >
> >   Assertion failed: (Res.getLLTTy(*getMRI()).isScalar() == Op.getLLTTy(*getMRI()).isScalar()), function buildExtOrTrunc, file /Users/gruyere/llvm-project/llvm/lib/CodeGen/GlobalISel/MachineIRBuilder.cpp, line 460.
> >
> >
> > Any thoughts?
>
>
> What does the failing GEP look like?

I've pushed a fix in 84bd8511085 <https://reviews.llvm.org/rG84bd8511085891a7c5f413f2d54d3a31b98105aa>. Post-commit review welcome, but I wanted to fix the crashes ASAP.

The issue was that vector GEPs can take the form of scalar base ptrs + vector offsets.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73403/new/

https://reviews.llvm.org/D73403