[PATCH] D73725: [DebugInfo] Avoid a quadratic-complexity corner case in LiveDebugValues

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: llvm/lib/CodeGen/LexicalScopes.cpp:327
+  getMachineBasicBlocks(DL, Set);
+  return Set.count(MBB) != 0;
 }
----------------
aprantl wrote:
> `return Set.count(MBB);`
> 
> is idiomatic, I think.
Does a LexicalScope always start at a MachineBasicBlock boundary? I.e. can `Set.count(MBB)` be non-zero even if no instruction in `MBB` has a location dominated by `Scope`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73725/new/

https://reviews.llvm.org/D73725