[PATCH] D73574: Omit "Contents of" headers when -no-leading-headers is specified.

Thu Jan 30 16:05:18 PST 2020

mtrent marked 2 inline comments as done.
mtrent added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/X86/macho-cstring-dump.test:10-11
 NO_ADDR: Contents of (__TEXT,__cstring) section
 NO_ADDR: Hello world\n
 NO_ADDR-NOT: 000000000000003b

----------------
jhenderson wrote:
> Not related to this patch, but I just spotted a bug here, which you might want to fix in a follow-up. This doesn't actually prove that the address is not printed, because it only shows that the address is not printed after "Hello world\n". I think just moving the line up a row would be enough, possibly in conjunction with --match-full-lines or similar.
So all of these FileCheck scripts are fragile in one way or another.

Changing the second line to "NO_ADDR-NEXT" would address the specific issue you address. It doesn't address the problem of the address being printed head of the "Contents of" line, or if the address is printed using some other format. What's more, FileCheck is 'resilient' to some things, such as differing whitespace: this is both a really good thing and a really bad thing depending on what production tools expect. 

I'm happy to receive the feedback and to consider approaches in the future. Additional points of view polishes my understanding of the problem.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73574/new/

https://reviews.llvm.org/D73574