[PATCH] D73677: MSVC Buggy version detection: turn pre-processor error into CMake configuration time check

Thu Jan 30 15:45:16 PST 2020

mehdi_amini added a comment.

In D73677#1850669 <https://reviews.llvm.org/D73677#1850669>, @rnk wrote:

> Seems like it didn't work quite right:
>  http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/14047

Thanks for the ping! Reverted in 1e417ba2d4d2 <https://reviews.llvm.org/rG1e417ba2d4d27a604d87462ff2d9e97ea9c5e770>

I'm not sure I understand the error though: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/14047/steps/stage%201%20cmake/logs/stdio ; it says "Unknown arguments specified"?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73677/new/

https://reviews.llvm.org/D73677