[PATCH] D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2)

Sriraman Tallam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 15:16:42 PST 2020


tmsriram marked an inline comment as done.
tmsriram added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineFunction.cpp:421
+  // Set the basic block that begins or ends every section.  For unique
+  // sections, the same basic block begins and ends it.
+  MachineBasicBlock *PrevMBB = nullptr;
----------------
davidxl wrote:
> It is not clear from the code below that the same BB begins and ends it for unique sections.
For unique sections, this comes already set above in line 388 and 389.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73674/new/

https://reviews.llvm.org/D73674





More information about the llvm-commits mailing list