[llvm] f7521dc - AMDGPU: Replace subtarget check with an assert

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 14:15:49 PST 2020


Author: Matt Arsenault
Date: 2020-01-30T14:15:26-08:00
New Revision: f7521dc292221e502d013e9505598df461659362

URL: https://github.com/llvm/llvm-project/commit/f7521dc292221e502d013e9505598df461659362
DIFF: https://github.com/llvm/llvm-project/commit/f7521dc292221e502d013e9505598df461659362.diff

LOG: AMDGPU: Replace subtarget check with an assert

This is already checked by the pattern subtarget predicate.

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp b/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
index ae9221d9994e..d887ed66a915 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
@@ -1852,8 +1852,7 @@ bool AMDGPUDAGToDAGISel::SelectSMRDImm(SDValue Addr, SDValue &SBase,
 bool AMDGPUDAGToDAGISel::SelectSMRDImm32(SDValue Addr, SDValue &SBase,
                                          SDValue &Offset) const {
 
-  if (Subtarget->getGeneration() != AMDGPUSubtarget::SEA_ISLANDS)
-    return false;
+  assert(Subtarget->getGeneration() == AMDGPUSubtarget::SEA_ISLANDS);
 
   bool Imm;
   if (!SelectSMRD(Addr, SBase, Offset, Imm))
@@ -1877,8 +1876,7 @@ bool AMDGPUDAGToDAGISel::SelectSMRDBufferImm(SDValue Addr,
 
 bool AMDGPUDAGToDAGISel::SelectSMRDBufferImm32(SDValue Addr,
                                                SDValue &Offset) const {
-  if (Subtarget->getGeneration() != AMDGPUSubtarget::SEA_ISLANDS)
-    return false;
+  assert(Subtarget->getGeneration() == AMDGPUSubtarget::SEA_ISLANDS);
 
   bool Imm;
   if (!SelectSMRDOffset(Addr, Offset, Imm))


        


More information about the llvm-commits mailing list