[PATCH] D73745: [InstCombine] Rename worklist methods; NFC

[Nikita Popov via Phabricator via llvm-commits]

nikic created this revision.
nikic added reviewers: spatel, lebedev.ri, xbolva00.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.

This renames `Worklist.AddDeferred()` to `Worklist.add()` and `Worklist.Add()` to `Worklist.push()`. The intention here is that `Worklist.add()` should be the go-to method for explicit worklist management, while the raw `Worklist.push()` is mostly for InstCombine internals. I will then migrate uses of `Worklist.push()` to `Worklist.add()` in followup changes.

Also happy to switch this to other names if these aren't good.

As suggested by @spatel on D73411 <https://reviews.llvm.org/D73411> I'm also changing the remaining method names to lowercase first character, in line with current coding standards.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73745

Files:
  llvm/include/llvm/Transforms/InstCombine/InstCombineWorklist.h
  llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
  llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
  llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp
  llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
  llvm/lib/Transforms/InstCombine/InstCombineInternal.h
  llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
  llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
  llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
  llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp
  llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp
  llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
  llvm/lib/Transforms/InstCombine/InstructionCombining.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73745.241572.patch
Type: text/x-patch
Size: 21660 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200130/a0655e4d/attachment.bin>