[PATCH] D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2)

[David Li via Phabricator via llvm-commits]

davidxl added a comment.

Can you add more test cases to cover things like bb labels, and different bb section types (cold, EH, unique etc). For cold section types, the merging should kick in etc.



================
Comment at: llvm/lib/CodeGen/MachineFunction.cpp:371
+    // A unique BB section can only be created if this basic block is not
+    // used for exception table computations.  Entry basic block cannot
+    // a section because the function starts one.
----------------
Fix comment. Missing the verb


================
Comment at: llvm/lib/CodeGen/MachineFunction.cpp:421
+  // Set the basic block that begins or ends every section.  For unique
+  // sections, the same basic block begins and ends it.
+  MachineBasicBlock *PrevMBB = nullptr;
----------------
It is not clear from the code below that the same BB begins and ends it for unique sections.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73674/new/

https://reviews.llvm.org/D73674