[PATCH] D72947: [CMake] llvm/runtimes: Do not override LLVM_* variables with just-built LLVM configurations
James Nagurne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 30 13:38:35 PST 2020
JamesNagurne added a comment.
In D72947#1850273 <https://reviews.llvm.org/D72947#1850273>, @phosek wrote:
> This looks reasonable to me, @smeenai & @beanz do you see any problem with this?
I'm not really married to the solution, to be honest. CACHE_VARIABLES is not intended to be used by an end-user.
However, this is the easiest/least verbose way to guarantee that LLVM_* configurations make it through to the runtimes build.
A different solution would be to generalize HandleLLVMOptions to take an alternate namespace to search for variables in, such that LLVM_ENABLE_PIC may be ON, but perhaps RUNTIMES_ENABLE_PIC is OFF, indicating correctly that LLVM was built with PIC and the runtimes will not be. That's a much more serious undertaking that I don't believe I have time for at this point.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72947/new/
https://reviews.llvm.org/D72947
More information about the llvm-commits
mailing list