[PATCH] D73677: MSVC Buggy version detection: turn pre-processor error into CMake configuration time check

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added inline comments.


================
Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:63
+    message(FATAL_ERROR "Host Visual Studio version 19.24 is known to miscompile part of LLVM (use -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON to ignore)")
+  endif()
+endif()
----------------
xbolva00 wrote:
> add “Please upgrade to version 16.5+ or use clang-cl” ?
@mehdi_amini: In addition to what @xbolva00 said, people on Windows usually refer to the Visual Studio version (16.4 here), not to the internal MSC version (19.24). I think from a user perspective, it is better to say `"Host Visual Studio version 16.4 is known to miscompile part of LLVM. Please upgrade to version 16.5+ or use clang-cl."`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73677/new/

https://reviews.llvm.org/D73677