[PATCH] D69808: [RISCV GlobalISel] Add lowerReturn for calling conv.

[weiwei via Phabricator via llvm-commits]

wwei marked an inline comment as done.
wwei added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVCallLowering.cpp:55
+    if (AssignFn)
+      return AssignFn(ValNo, ValVT, LocVT, LocInfo, Flags, State);
+    return false;
----------------
lewis-revill wrote:
> wwei wrote:
> > lewis-revill wrote:
> > > What's the case where this will be used? 
> > This is a reserved case. Currently, riscv backend does not implement `CCAssignFnForCall` and `CCAssignFnForReturn` , so `AssignFn` will be always null. If these two functions will be added later, the code is available directly.
> Correct me if I'm wrong but won't the assignments already have been done when you call `TLI.analyzeOutputArgs` from `lowerReturn`?
> 
> IE: `TLI.analyzeOutputArgs` currently calls `CC_RISCV`, which essentially performs the task of a `CCAssignFn`.
That's correct.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69808/new/

https://reviews.llvm.org/D69808