[PATCH] D64457: [GWP-ASan] Attempt to fix Android/ARM platforms.
Mitch Phillips via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 30 10:52:01 PST 2020
hctim marked an inline comment as done.
hctim added a subscriber: pcc.
hctim added inline comments.
================
Comment at: compiler-rt/lib/gwp_asan/guarded_pool_allocator.h:258
// variables in GWP-ASan.
- struct alignas(8) ThreadLocalPackedVariables {
+ struct alignas(64) ThreadLocalPackedVariables {
constexpr ThreadLocalPackedVariables() {}
----------------
hctim wrote:
> This alignment is manually required, as otherwise with my NDK (r18b) the bionic linker complains when running the test that the `executable's TLS segment is underaligned: alignment is 8, needs to be at least 64 for ARM64 Bionic`. Apparently this is fixed in the new NDKv21, but we can't update our bots to that at this time as the migration is nontrivial :( (NDKv21 breaks other things in standalone compiler-rt).
@pcc - do you think this is a reasonable solution to get it to build without pushing the new NDK/API version to the bots?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64457/new/
https://reviews.llvm.org/D64457
More information about the llvm-commits
mailing list