[PATCH] D73702: [WIP][mlir] enable conversion materialization for 1-1 type conversions

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Transforms/DialectConversion.h:46
+  /// Construct a TypeConverter. Derived classes must provide an implementation
+  /// of the ConversionMaterializer hook materializing a conversion from a set
+  /// of types into one result type by generating a cast operation of some kind.
----------------
Do we forsee instances where we may want multiple materializers registered? I want to move TypeConverter closer to how ConversionTarget works and allow for it to be more easily extended. I can imagine a situation where we may want to materialize differently depending on the type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73702/new/

https://reviews.llvm.org/D73702