[PATCH] D73483: [AMDGPU] fixed divergence driven shift operations selection

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 09:59:14 PST 2020


rampitec added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/shift-select.ll:57
+; GFX8: V_ASHRREV_I32_e64
+define amdgpu_kernel void @v_ashr_i32(i32 addrspace(1)* %out, i32 addrspace(1)* %in) {
+  %tid = call i32 @llvm.amdgcn.workitem.id.x()
----------------
rampitec wrote:
> You also need tests for i64.
Would be LGTM if there were i64 tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73483/new/

https://reviews.llvm.org/D73483





More information about the llvm-commits mailing list