[PATCH] D73708: [update_cc_test_checks] Don't attach CHECK lines to function declarations

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/UpdateTestChecks/update_cc_test_checks/def-and-decl.test:3
+
+# RUN: cp -f %S/Inputs/def-and-decl.c %t.c && %update_cc_test_checks %t.c
+# RUN: diff -u %S/Inputs/def-and-decl.c.expected %t.c
----------------
-f is not needed.


================
Comment at: llvm/test/tools/UpdateTestChecks/update_cc_test_checks/def-and-decl.test:4
+# RUN: cp -f %S/Inputs/def-and-decl.c %t.c && %update_cc_test_checks %t.c
+# RUN: diff -u %S/Inputs/def-and-decl.c.expected %t.c
+## Check that re-running update_cc_test_checks doesn't change the output
----------------
diff -u -> cmp


================
Comment at: llvm/utils/update_cc_test_checks.py:80
+      # If there is no line it is probably a builtin function -> skip
+    if node.get('inner') is None:
+        common.debug('Skipping function without body:', node['name'], '@', node['loc'])
----------------
Does `'inner' in node` work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73708/new/

https://reviews.llvm.org/D73708