[PATCH] D73685: Fix conversion of loops to GPU with no block/thread dimensions.

Thu Jan 30 03:42:28 PST 2020

ftynse added inline comments.

================
Comment at: mlir/test/Conversion/LoopsToGPU/no_blocks_no_threads.mlir:11
+  // CHECK-THREADS-NEXT: %[[BOUND:.*]] = subi %{{.*}}, %{{.*}} : index
+  // CHECK-THREADS-NEXT: %{{.*}} = constant 1 : index
+  // CHECK-THREADS-NEXT: %[[ONE:.*]] = constant 1 : index
----------------
herhut wrote:
> ftynse wrote:
> > Nit: do we really need to know there are two "constant 1" emitted?
> > More nit: does the absence of ops in between the given ops (-NEXT) matter?
> I took the NEXT from the other loop lowering test. The check for two constant 1 is there as we have two constants and I need to match the second. I want to make sure that unmapped grids/blocks actually are constant one. Is there a better way?
I see. It's fine this way.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73685/new/

https://reviews.llvm.org/D73685