[PATCH] D73685: Fix conversion of loops to GPU with no block/thread dimensions.

[Alex Zinenko via Phabricator via llvm-commits]

ftynse accepted this revision.
ftynse added a comment.
This revision is now accepted and ready to land.

Good catch, thanks!



================
Comment at: mlir/test/Conversion/LoopsToGPU/no_blocks_no_threads.mlir:11
+  // CHECK-THREADS-NEXT: %[[BOUND:.*]] = subi %{{.*}}, %{{.*}} : index
+  // CHECK-THREADS-NEXT: %{{.*}} = constant 1 : index
+  // CHECK-THREADS-NEXT: %[[ONE:.*]] = constant 1 : index
----------------
Nit: do we really need to know there are two "constant 1" emitted?
More nit: does the absence of ops in between the given ops (-NEXT) matter?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73685/new/

https://reviews.llvm.org/D73685