[PATCH] D73496: [IRCE] Use SCEVExpander to modify loop bound

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

I am a bit worried about that. As far as I remember RightValue needs to be in preheader because it is used in checks that decide whether or not we should go to pre/postloops. Does your case generate them? If yes, please add checks to make it explicit. If not, please construct a similar test with pre/postloop and make sure it passes with the fix.



================
Comment at: llvm/test/Transforms/IRCE/non-loop-invariant-rhs-instr.ll:4
+; this test must compile successfully
+; CHECK: constrained Loop
+define i32 @test(i32 %A, i64 %Len, i32 *%array) {
----------------
Please add `CHECK-LABEL: test` so that we could add more here later (maybe makes sense to rename it to `test_01`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73496/new/

https://reviews.llvm.org/D73496