[PATCH] D73559: AMDGPU: Account for dmask when computing image mem size

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

The memory size of image loads is a bit of bizarre concept, but I assume this helps with the GlobalISel stuff, so sure.

LGTM, one stylistic nitpick.



================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:950-953
+        } else
+          Info.memVT = memVTFromImageData(CI.getType(), DMaskLanes);
       } else
+        Info.memVT = EVT::getEVT(CI.getType());
----------------
As a stylistic note, I think it's nicer to have braces around both sides of an if-else, if one side requires it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73559/new/

https://reviews.llvm.org/D73559