[PATCH] D73157: AMDGPU/GlobalISel: Custom lower G_LOG/G_LOG10

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 01:43:32 PST 2020


nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

LGTM relative to your other legalizer changes, though I wonder: shouldn't the old instructions be erased somehow? Other legalizer code seems to have the same problem, though I don't know how this is actually supposed to work.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73157/new/

https://reviews.llvm.org/D73157





More information about the llvm-commits mailing list