[PATCH] D73639: [LLVM] Wrap extern TLS variable in getter Function

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 01:39:27 PST 2020


mstorsjo added a comment.

In D73639#1848054 <https://reviews.llvm.org/D73639#1848054>, @zero9178 wrote:

> I also just measured compiling X86ISelLowering. Once on trunk and once with the patch applied. Using GCC 9.2 as the compiler got me 31.572, 31.843 and 31.936 for the current master and 32.241, 32.370 and 32.306 with the patch applied. So it's measurable on my machine


I realized I had built my clang with asserts enabled, which might dilute the effect of the change. But despite disabling asserts, I can't measure any significant difference due to this change - it's almost the contrary effect, this change actually seems to make it marginally faster (both when built with GCC 7 and Clang 9).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73639/new/

https://reviews.llvm.org/D73639





More information about the llvm-commits mailing list