[PATCH] D72006: [MLIR] Added llvm.invoke and llvm.landingpad

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp:317
+
+  SmallVector<Type, 1> resultTypes(op.getResultTypes());
+  SmallVector<Type, 8> argTypes(
----------------
nit: This is unnecessary now.


================
Comment at: mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp:438
+        op.emitError("constant clauses expected");
+        emitRemark(bcOp.getLoc(), "global addresses expected as operand to "
+                                  "bitcast used in clauses for landingpad");
----------------
This seems like something that should be attached as a note.

See https://mlir.llvm.org/docs/Diagnostics/ for more details


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72006/new/

https://reviews.llvm.org/D72006